-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getPasswd: Check full prefix of line for username #81
Conversation
This fixes GoogleCloudPlatform#80 where the username is checked with Contains, resulting in improper parsing when a username is a suffix of another username.
Hi @Matir. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @adjackura |
/approved |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hopkiw, Matir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
/lgtm |
* container-build pipeline * use build script * address comments * fix bug * address comment * address comment * add e2e-test job and task * address comment * address comment * move go get * go mod tidy * fix merge messy * fix bug * add group
This fixes #80 where the username is checked with Contains, resulting in improper parsing when a username is a suffix of another username.